Scons: Remove Werror=False in SConscript files

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Scons: Remove Werror=False in SConscript files

This patch removes the overriding of "-Werror" in a handful of
cases. The code compiles with gcc 4.6.3 and clang 3.0 without any
warnings, and thus without any errors. There are no functional changes
introduced by this patch. In the future, rather than ypassing
"-Werror", address the warnings.

Testing Done

util/regress all passing (disregarding t1000 and eio)

Ship It!

So did these files get changed to remove the warning?  Or are there warnings with other versions of gcc?  I'm curious about the history here... it seems a little dangerous to take these off unless we know that the reasons for having them there have been addresses.

Andreas Hansson March 9, 2012, 6:32 a.m. (March 9, 2012, 6:32 a.m.)

There are no warnings with any version of gcc >= 4.2 at least. That's all I've been able to test. 

Was a -Wno-<insert warning here> flag added at some point perhaps? I cannot imagine that any older version of gcc would have problems when the more recent ones don't. Plus, if they do, then let's fix the code rather than disable -Werror. Agreed?

Andreas Hansson March 18, 2012, 8:42 p.m. (March 18, 2012, 8:42 p.m.)
```
Any additional thoughts on this one?
```

Nilay Vaish March 20, 2012, 9 a.m. (March 20, 2012, 9 a.m.)

Did you compile gem5.fast? I think the error shows up only when fast is being compiled.

Andreas Hansson March 20, 2012, 8:30 p.m. (March 20, 2012, 8:30 p.m.)
```
util/regress all passing for both opt and fast, so yes indeed
```

Ship It!

Diff:

Revision 2 (+7 -13)

Show changes

	src/SConscript
	src/cpu/testers/networktest/SConscript
	src/mem/ruby/common/SConscript
	src/mem/ruby/network/garnet/fixed-pipeline/SConscript

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Diff:

Status: Closed (submitted)