ruby: Added SC fail indication to trace profiling
Review Request #109 - Created Aug. 5, 2010 and submitted
| Information | |
|---|---|
| Brad Beckmann | |
| gem5 | |
| Reviewers | |
| Default | |
ruby: Added SC fail indication to trace profiling
Posted (Aug. 8, 2010, 1:51 p.m.)
-
src/mem/ruby/system/Sequencer.cc (Diff revision 1) -
What's the point of this status flag?
-
src/mem/ruby/system/Sequencer.cc (Diff revision 1) -
Why not just return false here.
-
src/mem/ruby/system/Sequencer.cc (Diff revision 1) -
and return true here.
Posted (Aug. 11, 2010, 12:57 p.m.)
-
src/mem/ruby/system/Sequencer.cc (Diff revision 2) -
Sorry, I wasn't looking for a comment. I mostly thought that it was strange to create the flag at all instead of just returning the status directly. Anyway, spent too much time on this already. I'm fine.