Ruby X86: problem in setting DMA port, related to the changeset 8850
Review Request #1102 - Created March 14, 2012 and submitted
| Information | |
|---|---|
| Nilay Vaish | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 8928:11ebb7f1d6de --------------------------- Ruby X86: problem in setting DMA port, related to the changeset 8850 I think since the dma port is assigned twice (once in SouthBridge.py, and once by Ruby somewhere) an extra port gets created which has no peer port. This results in a segmentation fault when a simulation is started. The posted patch solves the problem, but it is not the solution I am looking for. Andreas, do you have some idea how to handle this issue?
Some rudimentary testing has been carried out to ensure that ruby_fs, fs and mem_test are working.
Issue Summary
3
3
0
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| Still needed? | Andreas Hansson | April 4, 2012, 7:48 a.m. | Open |
| dma_ports.append([dma.test for dma in dmas])? | Andreas Hansson | April 4, 2012, 7:48 a.m. | Open |
| if self.ide.dma not in dma_ports? | Andreas Hansson | April 4, 2012, 7:48 a.m. | Open |
Posted (March 14, 2012, 5:57 p.m.)
I'm not sure I understand the context. Do you want to connect the config, pio and dma port to different interconnects (bus vs ruby)? If so, why? If all the ports of the device, e.g. the ide controller, are connected to the same interconnect, then I'd suggest to rely on attachIO and just pass the Ruby sequencer in question instead of the bus.
Review request changed
Updated (March 24, 2012, 6:27 a.m.)
Summary: |
|
|||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+9 -11) |
Posted (March 25, 2012, 8:23 p.m.)
Is it not possible to use the Ruby sequencers for all the connections to the DMA devices, i.e. config, pio and dma?
Posted (March 30, 2012, 3:57 a.m.)
Does any one else has any comments on this patch?
Ship It!
Review request changed
Updated (April 4, 2012, 4:39 a.m.)
Summary: |
|
||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||||||||
Diff: |
Revision 3 (+36 -55) |
Review request changed
Updated (April 4, 2012, 4:41 a.m.)
Testing Done: |
|
|---|
Review request changed
Updated (April 4, 2012, 4:46 a.m.)
Summary: |
|
|||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
Posted (April 4, 2012, 7:48 a.m.)
-
configs/example/ruby_mem_test.py (Diff revision 3) -
Still needed?
-
configs/example/ruby_mem_test.py (Diff revision 3) -
dma_ports.append([dma.test for dma in dmas])?
-
src/dev/x86/SouthBridge.py (Diff revision 3) -
if self.ide.dma not in dma_ports?
