Python: Make the All proxy traverse SimObject children as well
Review Request #1112 - Created March 21, 2012 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Python: Make the All proxy traverse SimObject children as well This patch changes the behaviour of the All proxy parameter to not only consider the direct children, but also do a pre-order depth-first traversal of the object tree and append all results from the children. This is used in a later patch to find all the memories in the system, independent of where they are located in the hierarchy.
util/regress all passing (disregarding t1000 and eio)
Posted (April 1, 2012, 4:25 a.m.)
No comments? It's not very controversial, but some feedback would be much appreciated. Thanks.
Seems fine with me, especially since it's only currently used for memories and this behavior makes more sense in that case
Agreed, if the All proxy is used only in one place for one purpose, and this change makes it suit that purpose better, then there's no reason not to accept it. It seems a little odd that there's no change in documentation to go along with this though... is there a comment somewhere that needs to be updated to reflect the new semantics? Heading off on a tangent to dreamland... it would be cool if we could integrate code and wiki changes so that features and their associated documentation could be reviewed and versioned together, and of course feature changes could be reviewed and accepted only if suitable documentation updates were included. Not today, though.