o3: move arm_v7a-like config to the o3 directory
Review Request #1123 - Created April 4, 2012 and discarded
| Information | |
|---|---|
| Korey Sewell | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
o3: move arm_v7a-like config to the o3 directory when this is in the Simulation directory, it prevents the running of other CPU models if O3 isn't compiled in, which obviously isn't desirable. You can replicate this error by just compiling the InOrderCPU model (or SimpleTiming) and trying to run hello world. There may be a cleaner way to do this without actually compiling in the arm_v7a-like config into gem5 but I dont know of one currently
Seems fine to me. Just one check, did you use hg move for moving the file?
Ship It!
Posted (April 5, 2012, 6:34 a.m.)
I appreciate the problem, but I don't think this is the right solution. Compiling all this stuff into gem5 just doesn't seem right. It seems like the real problem is the "from O3_ARM_v7a import *" lines in CacheConfig.py and Simulation.py. Basically the more specialized configuration should import the more general modules and not the other way around. Of course our current structure isn't really set up to make this easy. For now, can we just make the imports conditional on whether someone is actually using the corresponding options?
-
configs/common/CacheConfig.py (Diff revision 1) -
What about moving the import statement inside the if here?