Ruby: Use MasterPort base-class pointers where possible
Review Request #1124 - Created April 4, 2012 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Ruby: Use MasterPort base-class pointers where possible This patch simplifies future patches by changing the pointer type used in a number of the Ruby testers to use MasterPort instead of using a derived CpuPort class. There is no reason for using the more specialised pointers, and there is no longer a need to do any casting. With the latest changes to the tester, organising ports as readers and writes, things got a bit more complicated, and the "type" now had to be removed to be able to fall back to using MasterPort rather than CpuPort.
util/regress all passing (disregarding t1000 and eio)
Posted (April 5, 2012, 2:16 a.m.)
-
src/cpu/testers/directedtest/RubyDirectedTester.hh (Diff revision 1) -
Is this class still required?
Ship It!
Ship It!
Review request changed
Updated (April 6, 2012, 10:44 p.m.)
Description: |
|
|||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+26 -39) |
Ship It!
Ha...I spent way too much time debatting whether to use an enum or not. It didn't take long for that enum to be removed. :)