Config: Add command line options for disk image and memory size

Information
Submitter:	Jayneel Gandhi
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 8956:3c7003592b5f
---------------------------
Config: Add command line options for disk image and memory size
Added the options to Options.py for FS mode with backward compatibility. It is
good to provide an option to specify the disk image and the memory size from
command line since a lot of disk images are created to support different
benchmark suites as well as per user needs. Change in program also leads to
change in memory requirements. The memeory size option should be used while
using simgle memory. These options provide the interface to provide both disk
image and memory size from the command line and gives more flexibility.

Testing Done

Testing done to confirm backward compatibility

Issue Summary

Description	From	Last Updated	Status
What if there are multiple disks?	Andreas Hansson	April 17, 2012, 7:16 a.m.	Dropped
What if there are multiple memories? What about memories of different characteristics? (the comment also says disk image...)	Andreas Hansson	April 23, 2012, 9:54 a.m.	Resolved
Oversimplification when using distributed memories of different size/type.	Andreas Hansson	April 17, 2012, 7:16 a.m.	Dropped
Same as before.	Andreas Hansson	April 17, 2012, 7:16 a.m.	Dropped
Same as before.	Andreas Hansson	April 17, 2012, 7:16 a.m.	Dropped

Seems fine to me.

Andreas Hansson April 19, 2012, 6:08 a.m. (April 19, 2012, 6:08 a.m.)

I noticed this was pushed without fixing the copy paste error in the description, and without any comments describing the issue of a single vs. multiple memories. At the the first bit should be fixed.

Nilay Vaish April 21, 2012, 2:31 a.m. (April 21, 2012, 2:31 a.m.)

Andreas, I committed the patches. I am not too concerned about the commit
message. I agree there is repetition in it. But I don't think this requires
to be fixed as the message is not describing some thing incorrectly, or 
missing out on some thing that it should have described. Secondly, this
patch is not concerned about multiple memories / disk images. I don't see
why the commit message should mention it at all.

Andreas Hansson April 21, 2012, 3:41 a.m. (April 21, 2012, 3:41 a.m.)

I am not talking about the committ message, but rather my initial review stating that the message associated with the mem_size parameter is copy pasted from the disk image and not changed. I think it would make sense to have an accurate help message for the parameter, and thus would like to see it changed. Makes sense? I remarked upon this in my very first set of comments.

With respect to the multiple memories (or lack there of), I am merely requesting a comment line above the parameter stating that this assumes a single memory in e system and that for multiple memories the script itself has to be changed. I hope that also makes sense.

configs/common/Options.py (Diff revision 1)

What if there are multiple disks?

Show all issues

configs/common/Options.py (Diff revision 1)

What if there are multiple memories? What about memories of different characteristics?

(the comment also says disk image...)

Show all issues

configs/example/fs.py (Diff revision 1)

Oversimplification when using distributed memories of different size/type.

Show all issues

configs/example/fs.py (Diff revision 1)

Same as before.

Show all issues

configs/example/ruby_fs.py (Diff revision 1)

Same as before.

Show all issues

Seems to me this is just adding command-line access to override more fields of the SysConfig object.  Andreas is right that it's not a fully general solution, but limitation really lies with the way SysConfig works and not with Jayneel's patch.  This seems like a reasonable step until/unless someone rewrites the SysConfig stuff to be more general.

Summary:

-	Adding command line options for disk image and memory size
+	Config: Add command line options for disk image and memory size

Description:

~		Added the options to Options.py for FS mode with backward compatibility. It is good to provide an option to specify the disk image and the memory size from command line since a lot of disk images are created to support different benchmark suites as well as per user needs. Change in program also leads to change in memory requirements. These options provide the interface to provide both disk image and memory size from the command line and gives more flexibility.
	~	Changeset 8956:3c7003592b5f
	+
	+	Config: Add command line options for disk image and memory size
	+	Added the options to Options.py for FS mode with backward compatibility. It is
	+	good to provide an option to specify the disk image and the memory size from
	+	command line since a lot of disk images are created to support different
	+	benchmark suites as well as per user needs. Change in program also leads to
	+	change in memory requirements. The memeory size option should be used while
	+	using simgle memory. These options provide the interface to provide both disk
	+	image and memory size from the command line and gives more flexibility.

Branch:

+	default

Diff:

Revision 2 (+11 -3)

Show changes

	configs/common/Options.py
	configs/example/fs.py
	configs/example/ruby_fs.py

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Summary:

Description:

Changeset 8956:3c7003592b5f

Branch:

Diff:

Status: Closed (submitted)