SE Config: Changed se.py to support multithreaded mode
Review Request #1151 - Created April 16, 2012 and submitted
| Information | |
|---|---|
| Jayneel Gandhi | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 8957:b7a6a4605c44 --------------------------- SE Config: Changed se.py to support multithreaded mode Multithreaded programs did not run by just specifying the binary once on the command line of SE mode.The default mode is multi-programmed mode. Added check in SE mode to run multi-threaded programs in case only one program is specified with multiple CPUS. Default mode is still multi-programmed mode.
Ran to check backward compatibility with multi-programmed mode.
Posted (April 16, 2012, 5:42 a.m.)
-
configs/common/Options.py (Diff revision 1) -
we need a shorter name here... that's quite a lot to write on the command line IMO... how about "--mt"?
Review request changed
Updated (April 16, 2012, 8:38 a.m.)
Change Summary:
Updated the option to --mt on Cory's suggestion to shorten the flag name
Diff: |
Revision 2 (+7 -1) |
|---|
Review request changed
Updated (April 16, 2012, 9:07 a.m.)
Summary: |
|
||||||
|---|---|---|---|---|---|---|---|
Description: |
|
||||||
Branch: |
|
||||||
Diff: |
Revision 3 (+7 -1) |
Review request changed
Updated (April 16, 2012, 9:17 a.m.)
Summary: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||
Diff: |
Revision 4 (+7 -1) |
Ship It!
Posted (April 17, 2012, 5:55 a.m.)
Do we really need the command line option? If you have multiple processors but only one process, then you can infer that it must be a multithreaded process (else those other processors will never do anything). I suspect that it used to work this way and then got broken at some point. So you do need some kind of fix in se.py, I just think you can do it automatically without adding a command-line option.
Review request changed
Updated (April 17, 2012, 7:06 a.m.)
Description: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+4 -1) |
Posted (April 17, 2012, 7:09 a.m.)
Looks good. Description needs to be updated though.
Review request changed
Updated (April 17, 2012, 7:09 a.m.)
Diff: |
Revision 6 (+4 -1) |
|---|
Review request changed
Updated (April 17, 2012, 7:12 a.m.)
Summary: |
|
|||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||
Diff: |
Revision 7 (+4 -1) |
Ship It!