Syscalls: panic when the length argument to mmap is excessive.
Review Request #1168 - Created April 28, 2012 and submitted
| Information | |
|---|---|
| Gabe Black | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 8974:bc9705db542b --------------------------- Syscalls: panic when the length argument to mmap is excessive. If the length argument to mmap is larger than the arbitrary but reasonable limit of 4GB, there's a good chance that the value is nonsense and not intentional. Rather than attempting to satisfy the mmap anyway, this change makes gem5 panic to make it more apparent what's going wrong.
Is 4GB big enough?
Posted (May 18, 2012, 2:35 a.m.)
Would it make more sense for this to be a warning rather than a panic? I forget what the original symptom was we were trying to address, but I think it was something like gem5 crashing or hanging somewhat mysteriously. A warning should be as good as a panic message in eliminating the mystery, and the nice thing about a warning is that we don't have to worry as much about picking the right size.