x86 syscall emulation: Add the TCGETS ioctl to the whitelist of tty ioctls that
Review Request #1187 - Created May 11, 2012 and discarded
| Information | |
|---|---|
| Marc Orr | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 8979:c1ce40553d90 --------------------------- x86 syscall emulation: Add the TCGETS ioctl to the whitelist of tty ioctls that return -ENOTTY. This patch is a revised version of Vince Weaver's patch from 589.
Ran perlbench to confirm that that the workload is not held up by this ioctl. Furthermore, ran all spec workloads as best I could to confirm that there are no more ioctls called from them. Some of the inputs available to me were too large to run all workloads to completion. Also, some of workloads fail due to other causes. But I am fairly confident that this is the only ioctl that was causing problems. Also, ran the regression tester to confirm that everything compiles. I still need to examine the output a little more carefully to make sure everything passes.
Posted (May 11, 2012, 3:33 p.m.)
Marc, can you explain why you split these out to be per-ISA instead of common (at least for the linuxes)? I see that the x86 code is different, but I don't understand why it's different.
Review request changed
Updated (May 20, 2012, 1:37 p.m.)
Description: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+130 -63) |
Review request changed
Updated (May 20, 2012, 1:52 p.m.)
Description: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+119 -73) |
