Decode: Make the Decoder class defined per ISA.

Information
Submitter:	Gabe Black
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9006:aede609c2ff0
---------------------------
Decode: Make the Decoder class defined per ISA.

Testing Done

Ship It!

Creating the arch/generic files just to get rid of them two changesets later seems like serious overkill to me.  Why not just copy the decoder class into per-ISA versions now, then modify them in the other cset?  IMO that makes what's going on clearer than transitioning through this intermediate state.  I won't fight it if you want to keep things this way though.

Steve Reinhardt May 20, 2012, 8:37 a.m. (May 20, 2012, 8:37 a.m.)

I don't mean to sound too critical here... I can certainly see how this order of things would come about as you're working on it.  Just pointing out that in retrospect it's kind of a roundabout path from beginning to end.

Gabe Black May 20, 2012, 8:45 a.m. (May 20, 2012, 8:45 a.m.)

I don't disagree that it's a little strange. There are several reasons things ended up that way. First, I originally had a fairly different design for how this would work, and I tried to reuse bits of my earlier attempt rather than reimplement everything. Second, I found I was spending a lot of my gem5 time each weekend rediscovering what the heck I was doing last weekend, and that didn't leave a lot of time for new work. I wanted to get to a stable point and get this bit in place, and didn't want to go back rearchitecting things to make the history smoother since that would have made everything take even longer. I tried to keep the history fairly clean and making sense, and I'm pretty happy with how it ended up.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)