Seems fine, but I would like a quick check that nothing goes wrong with performance. After that feel free to commit

src/cpu/decode_cache.hh (Diff revision 1)

Why the change from the if/else structure in the original function?  That seemed reasonable to me, and avoided duplication of a couple of (admittedly simple) lines of code.

Show all issues

1. Gabe Black May 20, 2012, 8:53 a.m. (May 20, 2012, 8:53 a.m.)

   The idea was to isolate the different stages of the lookup. The first chunk looks in the address based cache, the second looks in the ExtMachInst based cache, and the third actually decodes the instruction. Each is responsible for fixing up the earlier caches if there's a hit. With the old structure, things were mixed together which, I thought, would make it more difficult to mix and match components, or at least see how this particular caching organization is structured.