I think the implementation of WAIT is not correct. Here is what the man page has to say

FUTEX_WAIT
              This operation atomically verifies that the futex address uaddr still
              contains the value val, and sleeps awaiting FUTEX_WAKE on this futex
              address.  If the timeout argument is non-NULL, its contents describe
              the maximum duration of the wait, which is infinite otherwise.  The
              arguments uaddr2 and val3 are ignored.


In the current implementation, val is being not checked.

src/sim/syscall_emul.cc (Diff revision 1)

Unnecessary white space.

Show all issues

src/sim/syscall_emul.cc (Diff revision 1)

A single DPRINTF is good enough.

Show all issues

src/sim/syscall_emul.cc (Diff revision 1)

Do you know the Linux kernel / pthreads behavior in this case?

Show all issues

1. Marc Orr May 18, 2012, 9:39 a.m. (May 18, 2012, 9:39 a.m.)

   No. But now that I'm looking a little closer at the code. I don't see why the lists can't be deleted when their last item is popped. It seems unnecessary to have a memory leak here.

src/sim/syscall_emul.cc (Diff revision 2)

I still need to move this stuff to (constants and futexMap) to a better place.

Show all issues

src/sim/syscall_emul.cc (Diff revision 2)

yes please

Show all issues

src/sim/syscall_emul.cc (Diff revision 2)

perhaps this should live in the system instead of being static? 

Show all issues

src/arch/alpha/linux/linux.hh (Diff revision 3)

how about TGT_EAGAIN?

Is EAGAIN the same for all OSes? should this be in kern/linux in that case?

Show all issues

1. Marc Orr May 20, 2012, 4:51 a.m. (May 20, 2012, 4:51 a.m.)

   Sure, I can rename to to TGT_EAGAIN. I don't know what TGT stand for or implies, so I guess that's why I wasn't using it.
   
   EAGAIN seems to be the same for all OSes except alpha:
   http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.git&a=search&h=HEAD&st=grep&s=define.EAGAIN&sr=1

src/kern/linux/linux.hh (Diff revision 3)

here again TGT_ seems to be the way others are done

Show all issues

src/kern/linux/linux.hh (Diff revision 3)

actually you did put it in kern/linux so why does it need to be in the alpha dir?

Show all issues

src/sim/syscall_emul.hh (Diff revision 3)

line length?

Show all issues

1. Marc Orr May 20, 2012, 4:51 a.m. (May 20, 2012, 4:51 a.m.)

   Woops.

src/arch/alpha/linux/linux.hh (Diff revision 3)

shouldn't this be 35 then? 

TGT is for target (as opposed to host) just to disambiguate #defines that would be defined anyway.

Show all issues

1. Marc Orr May 20, 2012, 4:59 a.m. (May 20, 2012, 4:59 a.m.)

   Yes :-).

Ship It!

Ship It!