Bus: Turn the PortId into a transport function parameter

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9032:f6e4b5b58356
---------------------------
Bus: Turn the PortId into a transport function parameter

The main aim of this patch is to arrive at a suitable port interface
for vector ports, including both the packet and the port id. This
patch changes the bus transport functions
(recvFunctional/Atomic/Timing) to require a PortId parameter
indicating the source port. Previously this information was passed by
setting the source field of the packet, and this is only required in
the case of a timing request.

With this patch, the use of the source and destination field is also
more restrictive, as they are only needed for timing accesses. The
modifications to these fields for atomic snoops is now removed
entirely, also making minor modifications to the cache.

Testing Done

util/regress all passing (disregarding t1000 and eio)

Issue Summary

Description	From	Last Updated	Status
how does this work?	Ali Saidi	May 24, 2012, 2:03 a.m.	Dropped

looks fine other than I'm not sure how something works exactly

src/mem/bus.cc (Diff revision 1)

how does this work?

Show all issues

Andreas Hansson May 23, 2012, 12:58 a.m. (May 23, 2012, 12:58 a.m.)

This was in fact a bug. getAddrRanges is called on a bus slave port (by a connected master port), and the id that used to be passed to the getAddrRanges is a slave port id. The portmap, however, is holding a number of bus master ports, and thus, we should never compare a slave port id and master port id (they both start from 0). I'm amazed this has not caused any problems up till now.

Ship It!

Description:

~		Changeset 9023:4f93374a2efa
	~	Changeset 9026:53259e232512

		Bus: Turn the PortId into a transport function parameter

		The main aim of this patch is to arrive at a suitable port interface
		for vector ports, including both the packet and the port id. This
		patch changes the bus transport functions
		(recvFunctional/Atomic/Timing) to require a PortId parameter
		indicating the source port. Previously this information was passed by
		setting the source field of the packet, and this is only required in
		the case of a timing request.

		With this patch, the use of the source and destination field is also
		more restrictive, as they are only needed for timing accesses. The
		modifications to these fields for atomic snoops is now removed
		entirely, also making minor modifications to the cache.

Diff:

Revision 2 (+75 -74)

Show changes

	src/mem/bus.hh
	src/mem/bus.cc
	src/mem/cache/cache_impl.hh

Description:

~		Changeset 9026:53259e232512
	~	Changeset 9032:f6e4b5b58356

		Bus: Turn the PortId into a transport function parameter

		The main aim of this patch is to arrive at a suitable port interface
		for vector ports, including both the packet and the port id. This
		patch changes the bus transport functions
		(recvFunctional/Atomic/Timing) to require a PortId parameter
		indicating the source port. Previously this information was passed by
		setting the source field of the packet, and this is only required in
		the case of a timing request.

		With this patch, the use of the source and destination field is also
		more restrictive, as they are only needed for timing accesses. The
		modifications to these fields for atomic snoops is now removed
		entirely, also making minor modifications to the cache.

Diff:

Revision 3 (+85 -81)

Show changes

	src/mem/bus.hh
	src/mem/bus.cc
	src/mem/cache/cache_impl.hh

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 9023:4f93374a2efa

Changeset 9026:53259e232512

Diff:

Description:

Changeset 9026:53259e232512

Changeset 9032:f6e4b5b58356

Diff:

Status: Closed (submitted)