Bus: Remove redundant packet parameter from isOccupied

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9027:7cd72272f04d
---------------------------
Bus: Remove redundant packet parameter from isOccupied

This patch merely remove the Packet* from the isOccupied member
function. Historically this was used to check if the packet was an
express snoop, but this is now done outside this function (where
relevant).

Testing Done

util/regress all passing (disregarding t1000 and eio)

Issue Summary

Description	From	Last Updated	Status
Although this isn't used today, would a derivative bus want the packet to determine this?	Ali Saidi	May 29, 2012, 6:28 p.m.	Dropped

src/mem/bus.cc (Diff revision 1)

Although this isn't used today, would a derivative bus want the packet to determine this?

Show all issues

Andreas Hansson May 25, 2012, 3:04 a.m. (May 25, 2012, 3:04 a.m.)

I'm tempted to say no. We are rather going in the direction where isOccupied will be implemented per layer (and also different for request/response/snoop response). Hence, I do not see a future use of the PacketPtr in this context.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)