Decoder: Remove the thread context getting/setting interface from the decoder.
Review Request #1233 - Created May 27, 2012 and discarded
| Information | |
|---|---|
| Gabe Black | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9033:d8e7ce211541 --------------------------- Decoder: Remove the thread context getting/setting interface from the decoder. This interface is no longer used, and getting rid of it simplifies the decoders and code that sets up the decoders. The thread context had been used to read architectural state which was used to contextualize the instruction memory as it came in. That was changed so that the state is now sent to the decoders to keep locally if/when it changes. That's significantly more efficient.
Ship It!
Posted (May 28, 2012, 12:47 a.m.)
The code change looks reasonable, but can you expand the commit message a bit? Looks like you not only got rid of the interface to get and set the TC, you got rid of the field that stores the TC altogether (i.e., you can't set it via the constructor now either). A sentence or two about why we don't need this anymore would help put this change in context.
Review request changed
Updated (May 28, 2012, 7:20 a.m.)
Description: |
|
|||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+15 -117) |
Ship It!