ISA: Turn the ExtMachInst NoopMachinst into the StaticInstPtr NoopStaticInst.

Information
Submitter:	Gabe Black
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9029:ed1b0bf94c92
---------------------------
ISA: Turn the ExtMachInst NoopMachinst into the StaticInstPtr NoopStaticInst.

This eliminates a use of the ExtMachInst type outside of the ISAs.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Why do you need to move this from isa_traits to x86_traits? How are you deciding what goes where? Why do ...	Nilay Vaish	June 3, 2012, 7:24 a.m.	Open

bump

I had viewed this patch last week, but forgot to write the review.

src/arch/x86/isa_traits.hh (Diff revision 1)

Why do you need to move this from isa_traits to x86_traits? 
How are you deciding what goes where? Why do we need two files?
Did you forgot add x86/isa_traits.cc to the diff?

Show all issues

Gabe Black June 3, 2012, 7:31 a.m. (June 3, 2012, 7:31 a.m.)

x86_traits.hh is for things which are like what goes in isa_traits.hh but are specific to x86 and aren't expected to be defined in other ISAs. It makes sense to have this defined for x86 because it's used in a lot of places, but it's not defined by x86 for consumption outside the ISA any more. In the future I'd like there to be a more well defined boundary between internal and external ISA stuff. I did accidentally leave off isa_traits.cc for x86.

Ship It!

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)