Port: Move retry from port base class to Master/SlavePort
Review Request #1253 - Created June 6, 2012 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9059:0b530c924765 --------------------------- Port: Move retry from port base class to Master/SlavePort This patch is the last part of moving all protocol-related functionality out of the Port base class. All the send/recv functions are already moved, and the retry (which still governs all the timing transport functions) is the only part that remained in the base class. The only point where this currently causes a bit of inconvenience is in the bus where the retry list is global and holds Port pointers (not Master/SlavePort). This is about to change with the split into a request/response bus and will soon be removed anyway. The patch has no impact on any regressions.
util/regress all passing (disregarding t1000 and eio)
Posted (June 6, 2012, 3:03 a.m.)
-
src/mem/bus.cc (Diff revision 1) -
Note that this is a temporary solution until the retry list is split for a split request/response bus. With the introduction of separate flow control for requests, responses and snoop responses each one of these "layers" will hold its own retry list.
Provided that this change is committed along side the change that removes the dynamic casts that is fine. The dynamic_casts shouldn't be left in the tip of the repository.
Ship It!