Port: Make getAddrRanges const

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9068:85173f3261a2
---------------------------
Port: Make getAddrRanges const

This patch makes getAddrRanges const throughout the code base. There
is no reason why it should not be, and making it const prevents adding
any unintentional side-effects.

Testing Done

util/regress all passing (disregarding t1000 and eio)

Issue Summary

Description	From	Last Updated	Status
Not that I'm awesome at Doxygen, but shouldn't this be /// @todo	Nathan Binkert	July 4, 2012, 5:15 p.m.	Resolved

src/arch/x86/interrupts.cc (Diff revision 1)

What's the need for this line?

Andreas Hansson June 7, 2012, 2:37 a.m. (June 7, 2012, 2:37 a.m.)

It sets the actual base address of the device, and used to be done as part of getAddrRanges. It can only be done after the CPU is set, but definitely does not need to be done every time getAddrRanges is called.

Description:

~		Changeset 9063:ca478511f67d
	~	Changeset 9068:85173f3261a2

		Port: Make getAddrRanges const

		This patch makes getAddrRanges const throughout the code base. There
		is no reason why it should not be, and making it const prevents adding
		any unintentional side-effects.

Diff:

Revision 2 (+57 -54)

Show changes

	src/arch/x86/interrupts.hh
	src/arch/x86/interrupts.cc
	src/dev/io_device.hh
	src/dev/io_device.cc
	src/dev/pciconfigall.hh
	src/dev/pciconfigall.cc
	src/dev/pcidev.hh
	src/dev/pcidev.cc
	27 more

Any feedback, opinions, or simply not exciting enough? :)

src/dev/x86/i8042.cc (Diff revision 2)

Not that I'm awesome at Doxygen, but shouldn't this be /// @todo

Show all issues

Ship It!

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 9063:ca478511f67d

Changeset 9068:85173f3261a2

Diff:

Status: Closed (submitted)