EventManager: Rename queue accessor and remove cast operator

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9104:0f9b39cb455d
---------------------------
EventManager: Rename queue accessor and remove cast operator

This patch renames the queue() accessor to the less ambigious
eventQueue, and also removes the cast operator. The queue() member
function cause problems in derived classes that declare members with
the same name, e.g. a MemObject subclass that has a packet queue on
its own. The operator is not causing any harm at this point, but as it
is not used there is little point in keeping it.

Testing Done

util/regress all passing (disregarding t1000 and eio)

I'm fine with getting rid of the cast operator, but how about we just rename the queue accessor to something less ambiguous like eventQueue()?  When we go to multiple event queues it probably will be handy to know which queue you're on at times.  I only use queue() once in my patch (http://reviews.gem5.org/r/846), and even there I'm not sure why that particular change is relevant, but still it would be nice not to lose the method entirely.

Summary:

-	EventManager: Remove the queue member function and operator
+	EventManager: Rename queue accessor and remove cast operator

Description:

~		Changeset 9104:a3655fd63449
	~	Changeset 9104:0f9b39cb455d

~		EventManager: Remove the queue member function and operator
	~	EventManager: Rename queue accessor and remove cast operator

~		This patch removes the queue() member function and cast operator as
~		they are never used outside the EventManager. The queue() member
	~	This patch renames the queue() accessor to the less ambigious
	~	eventQueue, and also removes the cast operator. The queue() member
		function cause problems in derived classes that declare members with
		the same name, e.g. a MemObject subclass that has a packet queue on
		its own. The operator is not causing any harm at this point, but as it
		is not used there is little point in keeping it.

Diff:

Revision 2 (+3 -8)

Show changes

src/sim/eventq.hh

Ship It!

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Summary:

Description:

Changeset 9104:a3655fd63449

Changeset 9104:0f9b39cb455d

Diff:

Status: Closed (submitted)