Ruby: Modify Scons so that we can put .sm files in extras
Review Request #1306 - Created July 14, 2012 and submitted
| Information | |
|---|---|
| Jason Lowe-Power | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9121:1653229eceb3 --------------------------- Ruby: Modify Scons so that we can put .sm files in extras Also allows for header files which are required in slicc generated code to be in a directory other than src/mem/ruby/slicc_interface.
Posted (Aug. 7, 2012, 1:14 a.m.)
Looks fine to me. I am guessing you already tested that all the protocols in the repo compile without any problems.
-
SConstruct (Diff revision 1) -
This is probably longer than 80 characters.
-
src/mem/protocol/SConscript (Diff revision 1) -
Why do we need this change?
Posted (Aug. 8, 2012, 1:06 a.m.)
-
src/mem/protocol/SConscript (Diff revision 1) -
This way if we need to include a file in the generated slicc code we can put that file in the EXTRAS directory and not have to modify mem/ruby/slicc_interface/RubySlicc_includes.hh.
Posted (Aug. 9, 2012, 2:33 a.m.)
-
src/mem/slicc/symbols/StateMachine.py (Diff revision 2) -
You might want to remove this line as well.
Review request changed
Updated (Aug. 14, 2012, 1:20 a.m.)
Ship It!
Posted (Aug. 26, 2012, 10:59 a.m.)
-
src/mem/protocol/SConscript (Diff revision 3) -
Do we support multiple protocols? Why the iteration?
-
src/mem/slicc/symbols/StateMachine.py (Diff revision 3) -
Opening namespace in a header? Should do so if that is the case.
Ship It!
What is the status of this patch? Can you check it in soon?