Ruby: Clean up topology changes
Review Request #1308 - Created July 14, 2012 and submitted
| Information | |
|---|---|
| Jason Lowe-Power | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9123:7166285d6ad2 --------------------------- Ruby: Clean up topology changes Moved instantiateTopology into Ruby.py and removed the topologies directory I'm not completely sure why the topology creation was in the src/ directory, but I think it was because previously the python needed to be compiled. Also added some extra inheritance to the topologies to clean up some issues in the legacy topologies
Posted (July 17, 2012, 9:22 p.m.)
I would like to avoid the creation of 'LegacyTopology' class. If there is something that only current topologies require / lack, we should fix that something in the individual topologies themselves or for all the topologies in the BaseTopology class.
Review request changed
Updated (July 19, 2012, 2:35 a.m.)
Change Summary:
I changed the name from LegacyTopology to SimpleTopology. It's "simple" in the sense that they only use a flat list of controllers to construct the topology.
Description: |
|
||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+48 -86) |
Posted (July 22, 2012, 11:38 a.m.)
-
configs/topologies/BaseTopology.py (Diff revisions 1 - 2) -
fatal() instead of panic()
Review request changed
Updated (July 23, 2012, 12:45 a.m.)
Description: |
|
||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+48 -86) |
Looks fine to me.