configs: add option for repeatedly switching back-and-forth between cpu types.

Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9148:a706a3187a5d
---------------------------
configs: add option for repeatedly switching back-and-forth between cpu types.

This patch adds a --repeat-switch option that will enable repeat core
switching at a user defined period (set with --switch-freq option).
currently, a switch can only occur between like CPU types. inorder CPU
switching is not supported.

*note*
this patch simply allows a config that will perform repeat switching, it
does not fix drain/switchout functionality. if you run with repeat switching
you will hit assertion failures and/or your workload with hang or die.

Testing Done

The options added to this config play nicely with the other options.
Ran with repeat switching on with various other options. Simulation
started and ran successfully while switching until an assertion failed
or the workload kernel panicked or hung due to drain/switchout bugs.

Issue Summary

Description	From	Last Updated	Status
My instinct is to see if we can get by with a single option here, e.g., if --switch-freq had no ...	Steve Reinhardt	July 23, 2012, 10:39 a.m.	Resolved
It looks like some of this added code duplicates code above... can we get away with reusing the switch_cpus list ...	Steve Reinhardt	July 23, 2012, 10:40 a.m.	Resolved

Summary:

-	configs: add options and frameworks for repeat switchout
+	configs: add option for repeatedly switching back-and-forth between cpu types.

Description:

~		Changeset 9121:2edce2d60331
	~	Changeset 9121:2877a0a82b1e

		configs: add option for repeatedly switching back-and-forth between cpu types.

		this patch adds a --repeat-switch option that will enable repeat core
		switching at a user defined period (set with --switch-freq option).
		currently, a switch can only occur between like CPU types. inorder CPU
		switching is not supported.

		note
		this patch simply allows a config that will perform repeat switching, it
		does not fix drain/switchout functionality. if you run with repeat switching
		you will hit assertion failures and/or your workload with hang or die.

Diff:

Revision 2 (+81 -17)

Show changes

	configs/common/Options.py
	configs/common/Simulation.py

configs/common/Options.py (Diff revision 2)

My instinct is to see if we can get by with a single option here, e.g., if --switch-freq had no default, then setting it would imply --repeat-switch and we wouldn't need --repeat-switch as an explicit option.

I see that the current method is consistent with -s/-w, but if we're worried about consistency, I'd be in favor of "fixing" -s/-w instead of introducing two new options here.

Thoughts?

Show all issues

configs/common/Simulation.py (Diff revision 2)

It looks like some of this added code duplicates code above... can we get away with reusing the switch_cpus list instead of creating a new repeat_switch_cpus list?

Show all issues

Tony Gutierrez July 23, 2012, 10:40 a.m. (July 23, 2012, 10:40 a.m.)

I did this because I wanted to make it easy for people use this functionality with --fast-forward however, I didn't add in --fast-forward support with --repeat-switch. It's there now.

Description:

~		Changeset 9121:2877a0a82b1e
	~	Changeset 9130:75db2cd47361

		configs: add option for repeatedly switching back-and-forth between cpu types.

~		this patch adds a --repeat-switch option that will enable repeat core
	~	This patch adds a --repeat-switch option that will enable repeat core
		switching at a user defined period (set with --switch-freq option).
		currently, a switch can only occur between like CPU types. inorder CPU
		switching is not supported.

		note
		this patch simply allows a config that will perform repeat switching, it
		does not fix drain/switchout functionality. if you run with repeat switching
		you will hit assertion failures and/or your workload with hang or die.

Diff:

Revision 3 (+91 -23)

Show changes

	configs/common/Options.py
	configs/common/Simulation.py

seems fine to me... this Simulate.py is a mess and it doesn't make it worse.

Description:

~		Changeset 9130:75db2cd47361
	~	Changeset 9147:0666da2ee93a

		configs: add option for repeatedly switching back-and-forth between cpu types.

		This patch adds a --repeat-switch option that will enable repeat core
		switching at a user defined period (set with --switch-freq option).
		currently, a switch can only occur between like CPU types. inorder CPU
		switching is not supported.

		note
		this patch simply allows a config that will perform repeat switching, it
		does not fix drain/switchout functionality. if you run with repeat switching
		you will hit assertion failures and/or your workload with hang or die.

Diff:

Revision 4 (+94 -15)

Show changes

	configs/common/Options.py
	configs/common/Simulation.py

Description:

~		Changeset 9147:0666da2ee93a
	~	Changeset 9147:fff4d7be1340

		configs: add option for repeatedly switching back-and-forth between cpu types.

		This patch adds a --repeat-switch option that will enable repeat core
		switching at a user defined period (set with --switch-freq option).
		currently, a switch can only occur between like CPU types. inorder CPU
		switching is not supported.

		note
		this patch simply allows a config that will perform repeat switching, it
		does not fix drain/switchout functionality. if you run with repeat switching
		you will hit assertion failures and/or your workload with hang or die.

Diff:

Revision 5 (+95 -16)

Show changes

	configs/common/Options.py
	configs/common/Simulation.py

Description:

~		Changeset 9147:fff4d7be1340
	~	Changeset 9147:fe0e01cdeb49

		configs: add option for repeatedly switching back-and-forth between cpu types.

		This patch adds a --repeat-switch option that will enable repeat core
		switching at a user defined period (set with --switch-freq option).
		currently, a switch can only occur between like CPU types. inorder CPU
		switching is not supported.

		note
		this patch simply allows a config that will perform repeat switching, it
		does not fix drain/switchout functionality. if you run with repeat switching
		you will hit assertion failures and/or your workload with hang or die.

Diff:

Revision 6 (+96 -16)

Show changes

	configs/common/Options.py
	configs/common/Simulation.py

Description:

~		Changeset 9147:fe0e01cdeb49
	~	Changeset 9148:a706a3187a5d

		configs: add option for repeatedly switching back-and-forth between cpu types.

		This patch adds a --repeat-switch option that will enable repeat core
		switching at a user defined period (set with --switch-freq option).
		currently, a switch can only occur between like CPU types. inorder CPU
		switching is not supported.

		note
		this patch simply allows a config that will perform repeat switching, it
		does not fix drain/switchout functionality. if you run with repeat switching
		you will hit assertion failures and/or your workload with hang or die.

Diff:

Revision 7 (+93 -19)

Show changes

	configs/common/Options.py
	configs/common/Simulation.py

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Summary:

Description:

Changeset 9121:2edce2d60331

Changeset 9121:2877a0a82b1e

Diff:

Description:

Changeset 9121:2877a0a82b1e

Changeset 9130:75db2cd47361

Diff:

Description:

Changeset 9130:75db2cd47361

Changeset 9147:0666da2ee93a

Diff:

Description:

Changeset 9147:0666da2ee93a

Changeset 9147:fff4d7be1340

Diff:

Description:

Changeset 9147:fff4d7be1340

Changeset 9147:fe0e01cdeb49

Diff:

Description:

Changeset 9147:fe0e01cdeb49

Changeset 9148:a706a3187a5d

Diff:

Status: Closed (submitted)