str: add an overloaded startswith() utility method

Information
Submitter:	Steve Reinhardt
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9131:f1095e71a98d
---------------------------
str: add an overloaded startswith() utility method
for various string types and use it in a few places.

Testing Done

Issue Summary

Description	From	Last Updated	Status
How about using STL strings instead and relying on compare?	Andreas Hansson	July 26, 2012, 5:14 p.m.	Open
Any particular reason for the C style strings instead of C++ STL strings?	Andreas Hansson	July 26, 2012, 5:14 p.m.	Open

Ship It!

src/base/str.hh (Diff revision 1)

How about using STL strings instead and relying on compare?

Show all issues

src/base/str.hh (Diff revision 1)

Any particular reason for the C style strings instead of C++ STL strings?

Show all issues

Steve Reinhardt July 27, 2012, 4:47 a.m. (July 27, 2012, 4:47 a.m.)

There are places (well at least one place) where both strings are C strings and not STL strings, so we need this overloaded version so that we can use this function without an explicit cast at the call site.  So as far as I can tell all three of these different versions are necessary if we want to avoid conversions at the call sites.

This C-string-only version could be implemented by converting 's' to an STL string and then using compare (or more specifically then calling one of the other overloaded versions), but that seems like more overhead than just calling strncmp.  If there's a good reason to avoid calling strncmp, though, I'm willing to change, as I don't think performance is all that critical here.

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)