Jason Lowe-Power got review request #1331!

Information
Submitter:	Jason Lowe-Power
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9139:8755d9aa06ac
---------------------------
Ruby: Add RubySystem parameter to MemoryControl SimObject to guarantee that RubySystem is created first.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Why not rely on a proxy and get the parent.any or similar? There should only be one ruby system surely.	Andreas Hansson	Aug. 2, 2012, 3:06 a.m.	Open

src/mem/ruby/system/MemoryControl.py (Diff revision 1)

Why not rely on a proxy and get the parent.any or similar? There should only be one ruby system surely.

Show all issues

Nilay Vaish Aug. 3, 2012, 11:50 p.m. (Aug. 3, 2012, 11:50 p.m.)
```
How does that help?
```

Andreas Hansson Aug. 5, 2012, 2:45 a.m. (Aug. 5, 2012, 2:45 a.m.)

It would make it uniform with how the System pointer is handled in the rest of the code base. It also avoids having to explicitly set it. Lastly it would ensure you've got a pointer already at creating time.

Just an idea of an improvement...not a must.

Ship It!

You have a pending review.

Review Board 2.0.15

Jason Lowe-Power got review request #1331!

This change has been marked as submitted.

Ruby: Add RubySystem parameter to MemoryControl SimObject to guarantee that RubySystem is created first.

Screenshots

Files

Issue Summary

Status: Closed (submitted)