Device: Remove overloaded pio_latency parameter
Review Request #1341 - Created Aug. 3, 2012 and submitted
| Information | |
|---|---|
| Andreas Hansson | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9153:cf12fe204e53 --------------------------- Device: Remove overloaded pio_latency parameter This patch removes the overloading of the parameter, which seems both redundant, and possibly incorrect. The PciConfigAll now also uses a Param.Latency rather than a Param.Tick. For backwards compatibility it still sets the pio_latency to 1 tick. All the comments have also been updated to not state that it is in simticks when it is not necessarily the case.
util/regress all passing (disregarding t1000 and eio)
Issue Summary
1
1
0
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| we should make this a reasonable number and bump the stats. | Ali Saidi | Aug. 5, 2012, 1:52 a.m. | Open |
looks good, but we should set these latency to reasonable numbers and bump the stats. For pio devices 100ns is probably good, and for pci like devices it's probably 30ns.
-
src/dev/Pci.py (Diff revision 1) -
we should make this a reasonable number and bump the stats.