O3: remove some unused buggy functions in the lsq (numLoadsReady)

Information
Submitter:	Nathanael Premillieu
Repository:	gem5
Branch:
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

O3: remove some unused buggy functions (numLoadsReady) in the lsq

Testing Done

As it was unused code, there is not difference in the final program.

The diff does not apply cleanly, hence it is not possible to view it.

Nathanael Premillieu Aug. 17, 2012, 4:12 a.m. (Aug. 17, 2012, 4:12 a.m.)

That's strange, I have just test it on the last version of the repository (using hg qimport) and it is applied with no problem.

Nathanael Premillieu Aug. 22, 2012, 9:20 a.m. (Aug. 22, 2012, 9:20 a.m.)

Is someone able to use the patch or everyone has the same problem as Nilay ?

Andreas Hansson Aug. 22, 2012, 10:11 a.m. (Aug. 22, 2012, 10:11 a.m.)

If you go to the "View diff" view you will see that it does not apply cleanly.

The best way to ensure that the patch works on the latest trunk is to use mercurial queues, pop all patches, do a fetch (pull + update), and then push your patch again and ensure that it does not cause any problems.

Change Summary:

Working diff.

Diff:

Revision 2 (-45)

Show changes

	src/cpu/o3/lsq.hh
	src/cpu/o3/lsq_impl.hh
	src/cpu/o3/lsq_unit.hh
	src/cpu/o3/lsq_unit_impl.hh

Thanks!

Ship It!

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Change Summary:

Diff:

Status: Closed (submitted)