Ruby: Remove RubyEventQueue

Information
Submitter:	Nilay Vaish
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9160:228050cfc21e
---------------------------
Ruby: Remove RubyEventQueue
This patch removes RubyEventQueue. Consumer objects now rely on RubySystem
or themselves for scheduling events.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Still want Time instead of Tick? Should it perhaps be Cycles once my patch is pushed?	Andreas Hansson	Aug. 21, 2012, 4:34 p.m.	Open

src/mem/ruby/common/Consumer.hh (Diff revision 1)

Still want Time instead of Tick? Should it perhaps be Cycles once my patch is pushed?

Show all issues

Nilay Vaish Aug. 22, 2012, 3:31 a.m. (Aug. 22, 2012, 3:31 a.m.)

You might have noticed that some of the functions in the same
class are using Tick. The places where Time has been used, the time
is actually in cycles with the clock period being decided by the
Ruby memory system.

I prefer going with this as of now. I might later on propose moving
SimObjects to ClockedObjects, where in time will be expressed in
terms of cycles of the clock of the object, instead of the cycles of 
the Ruby system.

Andreas Hansson Aug. 22, 2012, 7:03 a.m. (Aug. 22, 2012, 7:03 a.m.)

Ok, sounds good. We should sort it all out once the Cycles are in place.

Ship It!

This looks like a step in the right direction to me.  IIRC, one of the last remaining uses for the Ruby event queue was to allow decoupling Ruby from the rest of the system so that warmup traces could be replayed, which required advancing time from the Ruby perspective without really advancing time.  I forgot how (or even if) we ended up solving that.  I assume this change doesn't affect that issue?

Nilay Vaish Aug. 26, 2012, 4:11 p.m. (Aug. 26, 2012, 4:11 p.m.)

The cache warmup trace is replayed on the main event queue itself.
To start the replay, we change the head pointer of the queue and add an event
for the replaying the trace. Once the replay gets over, the head is put back
in its place. Thus, no events from the rest of the system can interfere while
the replay is on. Similarly, time is also saved and later on restored.

As per my understanding RubyEventQueue was only a wrapper around the main event queue.
At least that's how it behaved in the mainline. Its elimination just removes that
wrapper (though not completely).

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Status: Closed (submitted)