src/sim/simulate.cc (Diff revision 1)

Well spotted!

How about making the check (MaxTick - curTick()) > num_cycles and thus not "rely" on the behaviour of the overflow?

Show all issues

1. Tony Gutierrez Aug. 21, 2012, 7:14 a.m. (Aug. 21, 2012, 7:14 a.m.)

   Isn't that precisely the case when we don't have an overflow? Shouldn't it be:
   
   if (MaxTick - curTick() < num_cycles)
   
   or even:
   
   if (MaxTick - curTick() <= num_cycles) //explicitly set to MaxTick when num_cycles + curTick() would be equal to MaxTick
   
   ?

2. Andreas Hansson Aug. 21, 2012, 4:29 p.m. (Aug. 21, 2012, 4:29 p.m.)

   Absolutely right. Perhaps even put num_cycles on the left hand side.

Ship It!

Ship It!