sim: fix overflow check in simulate because Tick is now unsigned
Review Request #1361 - Created Aug. 21, 2012 and submitted
| Information | |
|---|---|
| Tony Gutierrez | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9163:3782c37f5403 --------------------------- sim: fix overflow check in simulate because Tick is now unsigned
Posted (Aug. 21, 2012, 7:06 a.m.)
-
src/sim/simulate.cc (Diff revision 1) -
Well spotted! How about making the check (MaxTick - curTick()) > num_cycles and thus not "rely" on the behaviour of the overflow?
Review request changed
Updated (Aug. 21, 2012, 7:16 a.m.)
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1 -1) |
Review request changed
Updated (Aug. 22, 2012, 3:13 a.m.)
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+3 -3) |
Review request changed
Updated (Aug. 22, 2012, 4:44 a.m.)
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+3 -5) |
Review request changed
Updated (Aug. 22, 2012, 4:46 a.m.)
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+3 -5) |
Ship It!
Ship It!
