Ruby Memory Controller: Fix clocking
Review Request #1362 - Created Aug. 21, 2012 and submitted
| Information | |
|---|---|
| Joel Hestness | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9156:0cdcf94f243f --------------------------- Ruby Memory Controller: Fix clocking Changeset 8937 switched the Ruby memory controller over to using the gem5 event queue instead of the Ruby event queue, but it did not correctly implement the clocking of the memory controller. This patch fixes that functionality by changing the memory controller over to traditional gem5 frequency specification.
Posted (Aug. 21, 2012, 8:51 a.m.)
-
src/mem/ruby/system/MemoryControl.py (Diff revision 1) -
How about changing SimObject to ClockedObject? Then, you would not need to add a new param clock in RubyMemoryControl.py. You would need to set it though. You would be able to make use of certain functions that ClockedObject class provides.
-
src/mem/ruby/system/RubyMemoryControl.cc (Diff revision 1) -
Joel, this is another line where schedule() is called. You might want to check if it needs to be fixed as well.
Review request changed
Updated (Aug. 21, 2012, 12:41 p.m.)
Change Summary:
Per Nilay's recommendation, shifted MemoryController over to MemObject to get ClockedObject semantics.
Diff: |
Revision 2 (+15 -17) |
|---|
Ship It!
