Ruby Memory Vector: Allow more than 4GB of memory
Review Request #1373 - Created Aug. 25, 2012 and submitted
| Information | |
|---|---|
| Nilay Vaish | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9170:84d304d618ed --------------------------- Ruby Memory Vector: Allow more than 4GB of memory The memory size variable was a 32-bit int. This meant that the size of the memory was limited to 4GB. This patch changes the type of the variable to 64-bit to support larger memory sizes. Thanks to Raghuraman Balasubramanian for bringing this to notice.
Issue Summary
2
1
1
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| If we want to align this with the rest of gem5 then the type should be Addr (which is typedef'ed ... | Andreas Hansson | Aug. 25, 2012, 3:35 p.m. | Open |
Posted (Aug. 25, 2012, 3:35 p.m.)
-
src/mem/ruby/system/MemoryVector.hh (Diff revision 1) -
If we want to align this with the rest of gem5 then the type should be Addr (which is typedef'ed to uint64_t). Perhaps a good idea to take the hit and change the memory-size related things to Addr?
Posted (Aug. 26, 2012, 7:53 a.m.)
Looking at this code reminds me that we should standardize this code on uint32_t, uint64_t, etc. That should be a separate patch though.
-
src/mem/ruby/system/MemoryVector.hh (Diff revision 1) -
Should this be 64 bits too?