src/arch/arm/table_walker.cc (Diff revision 1)

gat => got

Show all issues

src/arch/arm/table_walker.cc (Diff revision 1)

Is this to remember the current tc for the walk after squashing?

Show all issues

1. Ali Saidi Sept. 9, 2012, 11:04 p.m. (Sept. 9, 2012, 11:04 p.m.)

   yea.. we need it to kick off another walk.

src/arch/arm/table_walker.cc (Diff revision 1)

Is not really needed as this is the "else" block, but I'm happy to keep it here.

Show all issues

1. Ali Saidi Sept. 9, 2012, 11:04 p.m. (Sept. 9, 2012, 11:04 p.m.)

   intentionally put there since the "else" is created by  a return instruction. defensive programing and all.

src/cpu/simple/timing.hh (Diff revision 1)

const?

Show all issues

src/cpu/translation.hh (Diff revision 1)

bool isSquashed() const?

Show all issues

src/sim/tlb.hh (Diff revision 1)

const?

Who ever returns true?

isSquashed to be consistent in the naming?

Show all issues

1. Ali Saidi Sept. 9, 2012, 11:04 p.m. (Sept. 9, 2012, 11:04 p.m.)

   The version that is already implemented in the out of order and in-order cpu exec contextes. 
   
   I'd prefer to make it clear that there is a different version and not stick with the isXXXXX naming from the XC. 

Ship It!