ruby: reset timing after cache warm up

Information
Submitter:	Nilay Vaish
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9277:f576478175f1
---------------------------
ruby: reset timing after cache warm up
Ruby system was recently converted to a clocked object. Such objects maintain
state related to the time that has passed so far. During the cache warmup, Ruby
system changes its own time and the global time. Later on, the global time is
restored. So Ruby system also needs to reset its own time.

Testing Done

Issue Summary

Description	From	Last Updated	Status
I think this comment could be better and mention this is only for ruby warming up. There is probably as ...	Ali Saidi	Sept. 26, 2012, 11:10 a.m.	Open

I'm not too thrilled about this. Could you explain why we cannot rely on the global time keeping here? I'm not understanding the issue...

Andreas Hansson Sept. 26, 2012, 5:23 p.m. (Sept. 26, 2012, 5:23 p.m.)

I'm even inclined to create a ResettableClockedObject in between ClockedObject and the Ruby system. The whole idea of having a function to reset the clock makes me nervous.

Is there no other way Ruby could restore the cache state without advancing time?

Nilay Vaish Oct. 5, 2012, 3:51 a.m. (Oct. 5, 2012, 3:51 a.m.)

Andreas, it is not possible to create ResettableClockedObject class. This is
because the variables tick and cycles are private to class ClockedObject and
hence not accessible in ResettableClockedObject.

src/sim/clocked_object.hh (Diff revision 1)

I think this comment could be better and mention this is only for ruby warming up. There is probably as is missing as well.

Show all issues

Ship It!

Description:

~		Changeset 9249:4b5ef2c0dbd4
	~	Changeset 9277:f576478175f1

		ruby: reset timing after cache warm up
		Ruby system was recently converted to a clocked object. Such objects maintain
		state related to the time that has passed so far. During the cache warmup, Ruby
		system changes its own time and the global time. Later on, the global time is
		restored. So Ruby system also needs to reset its own time.

Diff:

Revision 2 (+16 -2)

Show changes

	src/mem/ruby/system/System.cc
	src/sim/clocked_object.hh

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 9249:4b5ef2c0dbd4

Changeset 9277:f576478175f1

Diff:

Status: Closed (submitted)