Configs: SE Script Fix for Alpha+Ruby Simulations.

Information
Submitter:	Malek Musleh
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9248:d0bc29eb9d01
---------------------------
Configs: SE Script Fix for Alpha+Ruby Simulations.

PIO Device Interrupts parameters are not found in the ALPHA ISA, only for x86. Hence running Alpha ISA + Ruby in SE Mode results in a parameters not found error.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Should this be part of the if-statement as well?	Andreas Hansson	Sept. 26, 2012, 8:16 a.m.	Open

Diff:

Revision 2 (+3 -3)

Show changes

configs/example/se.py

Ship It!

configs/example/se.py (Diff revision 2)

Should this be part of the if-statement as well?

Show all issues

Malek Musleh Sept. 26, 2012, 10:11 a.m. (Sept. 26, 2012, 10:11 a.m.)

If this is moved to be part of the if-statement, then fatal("CPU system.cpu0 has no interrupt controller.") in /cpu/base.cc is encountered. Not sure if its better to do a check on the ISA + system Mode to determine if fatal should be invoked.

Andreas Hansson Sept. 26, 2012, 5:18 p.m. (Sept. 26, 2012, 5:18 p.m.)

Ok, that's fine then. It's just a bit counter-intuitive to create it always, and only connect the ports in the x86 case. Could you perhaps add a short comment stating that the interrupt controller is always present, but only in the x86 does it have message ports that need to be connected?

It would also be great if the description would stick to the 65 char limit.

Summary:

-	Configs: SE Script Fix for Alpha+Ruby Simulations. PIO Device Interrupts parameters are not found in the ALPHA ISA, only for x86.
+	Configs: SE Script Fix for Alpha+Ruby Simulations.

Description:

~		Changeset 9250:fc633cd6aca4
	~	Changeset 9248:1875a911d9a6

~		Configs: SE Script Fix for Alpha+Ruby Simulations. PIO Device Interrupts parameters are not found in the ALPHA ISA, only for x86.
	~	Configs: SE Script Fix for Alpha+Ruby Simulations.
	+
	+	PIO Device Interrupts parameters are not found in the ALPHA ISA, only for x86. Hence running Alpha ISA + Ruby in SE Mode results in a parameters not found error.

Diff:

Revision 3 (+3 -3)

Show changes

configs/example/se.py

Description:

~		Changeset 9248:1875a911d9a6
	~	Changeset 9248:d0bc29eb9d01

		Configs: SE Script Fix for Alpha+Ruby Simulations.

		PIO Device Interrupts parameters are not found in the ALPHA ISA, only for x86. Hence running Alpha ISA + Ruby in SE Mode results in a parameters not found error.

Diff:

Revision 4 (+5 -3)

Show changes

configs/example/se.py

Ship It!

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Diff:

Summary:

Description:

Changeset 9250:fc633cd6aca4

Changeset 9248:1875a911d9a6

Diff:

Description:

Changeset 9248:1875a911d9a6

Changeset 9248:d0bc29eb9d01

Diff:

Status: Closed (submitted)