Review Board 2.0.15


Provide Python script command line options to set cache latencies

Review Request #1454 - Created Sept. 28, 2012 and updated

Information
Lluís Vilanova
gem5
Reviewers
Default 
Simplifies initial testing of different cache latency values with the example scripts.

   

  


 


 

  

  






 
 
Issue Summary

 

  

   
    
    1
   
   
    
    1
   
   
    
    0
   
   
    
    0
   
  

  

   

    
    
   

   

    
    
   

  

 

 

  

   
    

     Description
     From
     Last Updated
     Status
    

   
   

















    

     Although the overall patch looks good, I'm not to thrilled that all the default values now are moved to the ...
     Andreas Hansson
     Oct. 23, 2012, 6:29 a.m.
     Open
    








   
  

 









  
 


  

 













 



 













 



 













 



 













 



 













 



 

  


 

  

   

   
Review request changed

   
Updated  (Oct. 23, 2012, 4:18 a.m.)

  

  




   
Change Summary:

   
Rebase on r9308.





   



    

     
Diff:

     
      
 Revision 3 (+35 -11)
Show changes
 
    configs/common/CacheConfig.py 
    configs/common/Options.py 
    configs/ruby/MESI_CMP_directory.py 
    configs/ruby/MI_example.py 
    configs/ruby/MOESI_CMP_directory.py 
    configs/ruby/MOESI_CMP_token.py 
    configs/ruby/MOESI_hammer.py 
    configs/ruby/Network_test.py 
 

     		
    



   




  

 


  

 

















 



 

  


 


  



   

   
Andreas Hansson

   
Posted  (Oct. 23, 2012, 6:29 a.m.)


  


  


  

   



  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    But isn't that the same thing that's happening with associativity and size for that same example? For example, the associativity settings for "O3_ARM_v7a_ICache" are being overridden by "options.l1i_assoc" in "CacheConfig.py".
    
    
    
   
    2. 


   
  2. 
    
    
     
    
      
     
    
     
    Somehow we should fix that as well, imho :)

Afraid I cannot suggest an easy solution at this point. Any ideas?
    
    
    
   
    3. 


   
  3. 
    
    
     
    
      
     
    
     
    parser.add_option("--l1i_assoc", type="int")
options, args = parser.parse_options(...)
extra = dict()
if options.l1i_assoc is not None:
    extra["assoc"] = options.l1i_assoc
icache = O3_ARM_v7a_ICache(..., **extra)
    
    
    
   
    4. 

   


  




   







    

     
     

      

       
        

         
          configs/common/CacheConfig.py
          

           (Diff revision 3)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Although the overall patch looks good, I'm not to thrilled that all the default values now are moved to the Options.py file instead of being per "configuration" as in the O3_ARM_v7aL2 class.

It would be better to not use the option unless it is explicitly set by the user.


     





 

  
  
  
  
  
  Show all issues