dev: Add missing inline declarations

Download Diff
View Diff

Information
Submitter:	Ali Saidi
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9322:fe7c1d064cda
---------------------------
dev: Add missing inline declarations

Testing Done

Expand All
Collapse All

Ship It!

No objections, but does it really matter?

Andreas Sandberg Oct. 25, 2012, 6:54 p.m. (Oct. 25, 2012, 6:54 p.m.)

Since they aren't static or inline, the compiler exports the symbols. The reason this bites us at is that the "sim: Include object header files in SWIG interfaces" (#1501) includes the header file in the SWIG wrapper, which creates a link error by exporting a second version the symbols.

Andreas Hansson Oct. 25, 2012, 6:59 p.m. (Oct. 25, 2012, 6:59 p.m.)

Makes perfect sense. Would have been great to see in the patch description :). Thanks for clearing that question mark.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)