I'd love to see this, but I'd rather see better encapsulation.

src/sim/core.hh (Diff revision 1)

This should go.

Show all issues

1. Nilay Vaish Nov. 14, 2012, 9:12 p.m. (Nov. 14, 2012, 9:12 p.m.)

   I think we need a global notion of time, which is separate from
   the time maintained by an particular event queue.

2. Nathan Binkert Nov. 15, 2012, 2:10 a.m. (Nov. 15, 2012, 2:10 a.m.)

   I wasn't objecting to that.  I was objecting to the fact that this is a reference to an internal value of another datastructore.

src/sim/core.hh (Diff revision 1)

This should become:
inline Tick curTick { return mainEventQueue.curTick(); }

Show all issues

1. Nilay Vaish Nov. 14, 2012, 9:12 p.m. (Nov. 14, 2012, 9:12 p.m.)

   This would require making mainEventQueue visible in sim/core.hh. This is not possible
   as of now given the dependency structure of the header files.

2. Nathan Binkert Nov. 15, 2012, 2:10 a.m. (Nov. 15, 2012, 2:10 a.m.)

   Yuck. :/  Can you at least name the variable "mainEventQueueCurTick" and define it on the line below where mainEventQueue is defined in eventq.cc?  I'd at least like it to be very clear what is going on.  I'm hoping that some day it will go away, and if the two are right next to each other, that will be much easier to accomplish.
   
   (The location of the declaration in core.hh is fine).
   
   An alternative is to remove the curTick function from core.hh and move it into eventq.hh.  This might require adding a some #includes to files, but it would be much better from an encapsulation standpoint.

3. Steve Reinhardt Nov. 15, 2012, 3:44 a.m. (Nov. 15, 2012, 3:44 a.m.)

   I'm with Nate on this one, so far... if including eventq.hh here causes a circular dependency, let's fix that rather than doing something suboptimal to the code just to avoid that superficial problem.  For example, eventq.hh could be split up into two parts, one with just the basic class definition(s) and the extern mainEventQueue declaration, and another with all the inlined code that I'm sure is what's forcing the other includes.

src/sim/core.hh (Diff revision 1)

Is this still needed?

Show all issues

1. Nilay Vaish Nov. 14, 2012, 9:12 p.m. (Nov. 14, 2012, 9:12 p.m.)

   Ruby resets that current tick while doing warming up the caches.

2. Nathan Binkert Nov. 15, 2012, 2:10 a.m. (Nov. 15, 2012, 2:10 a.m.)

   Ok.  Then I think it should be call a setter function on the main event queue.

src/sim/core.cc (Diff revision 1)

This should go

Show all issues

src/sim/eventq.hh (Diff revision 1)

Shouldn't this be private with a public accessor?

Show all issues

Much better.  Thanks!

Thanks for the effort to clean this up!