ruby: move files from ruby/system to ruby/structures

Information
Submitter:	Nilay Vaish
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 10284:6f0f19a89a4c
---------------------------
ruby: move files from ruby/system to ruby/structures

The directory ruby/system is crowded and unorganized. Hence, the files the
hold actual physical structures, are being moved to the directory
ruby/structures.  This includes Cache Memory, Directory Memory,
Memory Controller, Wire Buffer, TBE Table, Perfect Cache Memory, Timer Table,
Bank Array.

The directory ruby/systems has the glue code that holds these structures
together.

Testing Done

Any opinions?

Could you add an explanation for what kind of file goes in each folder to the commit message?

Andreas Hansson Jan. 9, 2013, 11:55 p.m. (Jan. 9, 2013, 11:55 p.m.)

Same here, what is the rationale for the split in terms of what kind of file goes where? I'm also curios as to why the directory is called "system" to start with :-)

If we try and match this with the classic memory system, should we do something similar? Would "components" be a better name than "structures" perhaps?

Just random thoughts...

Jason Lowe-Power Jan. 10, 2013, 12:06 a.m. (Jan. 10, 2013, 12:06 a.m.)

Maybe interface instead of system? It seems that all that's left in there is there port/sequencer interfaces, and System.cc/hh. 

I certainly don't feel strongly about this, but it may help understanding of the code for new developers.

Nilay Vaish Jan. 12, 2013, 12:38 p.m. (Jan. 12, 2013, 12:38 p.m.)
```
I'll rename the directories as components and interface.
```

Description:

~		Changeset 9360:9dc3879af7c9
	~	Changeset 10284:6f0f19a89a4c

~		ruby: move files from ruby/system to ruby/structures
~		I felt that the directory ruby/system is getting crowded. Hence, I am thinking
~		of the moving some of the files to ruby/structures directory. This includes
~		Cache Memory, Directory Memory, Memory Controller, Wire Buffer, TBE Table,
~		Perfect Cache Memory, Timer Table, Bank Array.
	~	ruby: move files from ruby/system to ruby/structures
	~
	~	The directory ruby/system is crowded and unorganized. Hence, the files the
	~	hold actual physical structures, are being moved to the directory
	~	ruby/structures. This includes Cache Memory, Directory Memory,
	+	Memory Controller, Wire Buffer, TBE Table, Perfect Cache Memory, Timer Table,
	+	Bank Array.
	+
	+	The directory ruby/systems has the glue code that holds these structures
	+	together.

Diff:

Revision 2 (+6108 -6177)

Show changes

	src/mem/ruby/SConscript
	src/mem/ruby/buffers/MessageBuffer.hh
	src/mem/ruby/buffers/MessageBuffer.cc
	src/mem/ruby/buffers/MessageBufferNode.hh
	src/mem/ruby/buffers/MessageBufferNode.cc
	src/mem/ruby/buffers/SConscript
	src/mem/ruby/common/MachineID.hh
	src/mem/ruby/common/NetDest.hh
	90 more

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Description:

Changeset 9360:9dc3879af7c9

Changeset 10284:6f0f19a89a4c

Diff:

Status: Closed (submitted)