Ruby: Sequencer -- convert deadlock panic to Ticks
Review Request #1592 - Created Dec. 15, 2012 and submitted
| Information | |
|---|---|
| Malek Musleh | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9377:65bf3ff8d02a --------------------------- Ruby: Sequencer -- convert deadlock panic to Ticks This patch converts the panic() print outs in the Sequencer::wakeup() call from ruby cycles to Ticks(). This makes it easier to debug deadlocks with the ProtocolTrace flag so the issue time indicated in the panic message can be quickly searched for.
Happy for this to go out, but I had a thought: Is the Sequencer not a ClockedObject? If so, it will by default inherit the clock of its parent (the RubySystem) and so there should be no need to use the system_ptr->clockPeriod() but simply do "clockPeriod()". If the latter is not the case, perhaps it is worth changing it before pushing this patch?
Review request changed
Updated (Jan. 4, 2013, 12:36 a.m.)
Description: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+4 -4) |
Review request changed
Updated (Jan. 4, 2013, 12:59 a.m.)
Description: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+4 -4) |
