Config: Move Ruby Objs to RubySystem in obj hierarchy

Information
Submitter:	Malek Musleh
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9376:fba1eda1cb0f
---------------------------
Config: Move Ruby Objs to RubySystem in obj hierarchy

This patch moves the contollers to be children of the ruby_system instead of 'system' under the python object hierarchy. This is so that these objects can inherit some of the ruby_system's parameter values without resorting to calling a global system pointer during run-time. The Ruby Objects should be direct children of the ruby_system instead of the main system object.

Testing:

Testing Done

Issue Summary

Description	From	Last Updated	Status
Should this not also include dir_cntrls while we are at it?	Andreas Hansson	Jan. 4, 2013, 12:35 a.m.	Resolved

configs/ruby/Ruby.py (Diff revision 1)

Should this not also include dir_cntrls while we are at it?

Show all issues

Malek Musleh Jan. 4, 2013, 12:35 a.m. (Jan. 4, 2013, 12:35 a.m.)

Apparently the directory (all in fact) controllers were children of the 'System' object instead of the 'RubySystem' object. I updated the patch so that they become part of ruby_system, and because the Sequencer is a child of the L1 Controller, it inherits the RubySystem clock period now. Also, the previous revision of this patch created a add child warning: add_child('cpu_sequencers'): child 'sequencer sequencer sequencer sequencer sequencer sequencer sequencer sequencer sequencer sequencer sequencer sequencer sequencer sequencer sequencer sequencer' already has parent: since the sequencer already had the L1 controller as a parent, and then I was reassigning it a new parent 'RubySystem'. This update fixes the warning.

Summary:

-	Config: Move Ruby Seqs under RubySystem in python obj hierarchy
+	Config: Move Ruby Objs to RubySystem in obj hierarchy

Description:

~		Changeset 9373:615a87a531f6
	~	Changeset 9373:dc294cf7eb0b

~		Config: Move Ruby Seqs under RubySystem in python obj hierarchy
	~	Config: Move Ruby Objs to RubySystem in obj hierarchy
	+
	+	This patch moves the contollers to be children of the ruby_system instead of 'system' under the python object hierarchy. This is so that these objects can inherit some of the ruby_system's parameter values without resorting to calling a global system pointer during run-time. The Ruby Objects should be direct children of the ruby_system instead of the main system object.
	+
	+	Testing:

Diff:

Revision 2 (+23 -23)

Show changes

	configs/ruby/MESI_CMP_directory.py
	configs/ruby/MI_example.py
	configs/ruby/MOESI_CMP_directory.py
	configs/ruby/MOESI_CMP_token.py
	configs/ruby/MOESI_hammer.py

Description:

~		Changeset 9373:dc294cf7eb0b
	~	Changeset 9376:fba1eda1cb0f

		Config: Move Ruby Objs to RubySystem in obj hierarchy

		This patch moves the contollers to be children of the ruby_system instead of 'system' under the python object hierarchy. This is so that these objects can inherit some of the ruby_system's parameter values without resorting to calling a global system pointer during run-time. The Ruby Objects should be direct children of the ruby_system instead of the main system object.

		Testing:

Diff:

Revision 3 (+23 -23)

Show changes

	configs/ruby/MESI_CMP_directory.py
	configs/ruby/MI_example.py
	configs/ruby/MOESI_CMP_directory.py
	configs/ruby/MOESI_CMP_token.py
	configs/ruby/MOESI_hammer.py

You have a pending review.

Review Board 2.0.15

This change has been discarded.

Screenshots

Files

Issue Summary

Summary:

Description:

Changeset 9373:615a87a531f6

Changeset 9373:dc294cf7eb0b

Diff:

Description:

Changeset 9373:dc294cf7eb0b

Changeset 9376:fba1eda1cb0f

Diff:

Status: Discarded