config: Move Ruby Objs to RubySystem in obj hierarchy

Information
Submitter:	Malek Musleh
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9376:abfda926f810
---------------------------
config: Move Ruby Objs to RubySystem in obj hierarchy

This patch moves the contollers to be children of the ruby_system instead of 'system' under the python object hierarchy. This is so that these objects can inherit some of the ruby_system's parameter values without resorting to calling a global system pointer during run-time. The Ruby Objects should be direct children of the ruby_system instead of the main system object.

Testing:

Testing Done

LGTM

I suppose the summary should be "config:" as opposed to "Config:", but that's all

Summary:

-	Config: Move Ruby Objs to RubySystem in obj hierarchy
+	config: Move Ruby Objs to RubySystem in obj hierarchy

Description:

~		Changeset 9376:fba1eda1cb0f
	~	Changeset 9376:5586bcc48d3c

~		Config: Move Ruby Objs to RubySystem in obj hierarchy
	~	config: Move Ruby Objs to RubySystem in obj hierarchy

		This patch moves the contollers to be children of the ruby_system instead of 'system' under the python object hierarchy. This is so that these objects can inherit some of the ruby_system's parameter values without resorting to calling a global system pointer during run-time. The Ruby Objects should be direct children of the ruby_system instead of the main system object.

		Testing:

Diff:

Revision 2 (+23 -23)

Show changes

	configs/ruby/MESI_CMP_directory.py
	configs/ruby/MI_example.py
	configs/ruby/MOESI_CMP_directory.py
	configs/ruby/MOESI_CMP_token.py
	configs/ruby/MOESI_hammer.py

There is one more protocol file that needs to be updated.

Description:

~		Changeset 9376:5586bcc48d3c
	~	Changeset 9376:abfda926f810

		config: Move Ruby Objs to RubySystem in obj hierarchy

		This patch moves the contollers to be children of the ruby_system instead of 'system' under the python object hierarchy. This is so that these objects can inherit some of the ruby_system's parameter values without resorting to calling a global system pointer during run-time. The Ruby Objects should be direct children of the ruby_system instead of the main system object.

		Testing:

Diff:

Revision 3 (+25 -25)

Show changes

	configs/ruby/MESI_CMP_directory.py
	configs/ruby/MI_example.py
	configs/ruby/MOESI_CMP_directory.py
	configs/ruby/MOESI_CMP_token.py
	configs/ruby/MOESI_hammer.py
	configs/ruby/Network_test.py

I am not opposed to committing this patch. But I am not convinced 
if all the controllers should be under the object ruby_system.
If we ever move to a system in which different controllers have
different frequencies of operation, it seems that all the cache
controllers private to a core would be more tightly bound to
core, than being bound to memory system.

Andreas Hansson Jan. 8, 2013, 5:37 p.m. (Jan. 8, 2013, 5:37 p.m.)

I support that observation, and it would be good to have a separation of L1 controllers, L2 controllers, interconnect and memory in terms of clock domains. That said, I think the current change is a good step in not using system_ptr->getClock() at any point.

Could we perhaps start with the current patch, remove the getClock() from the RubySystem all together, and then follow up by shifting the bits and pieces around until they are all in the right clock domain?

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Summary:

Description:

Changeset 9376:fba1eda1cb0f

Changeset 9376:5586bcc48d3c

Diff:

Description:

Changeset 9376:5586bcc48d3c

Changeset 9376:abfda926f810

Diff:

Status: Closed (submitted)