config: Remove O3 dependencies
Review Request #1608 - Created Jan. 7, 2013 and submitted
| Information | |
|---|---|
| Ali Saidi | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9457:fd01ef3f4a58 --------------------------- config: Remove O3 dependencies The default cache configuration script currently import the O3_ARM_v7a model configuration, which depends on the O3 CPU. This breaks if gem5 has been compiled without O3 support. This changeset removes the dependency by only importing the model if it is requested by the user. As a bonus, it actually removes some code duplication in the configuration scripts.
Issue Summary
3
3
0
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| Ali, for how many different cpu configurations are you ready to carry out this analysis? There can be inifinitly many ... | Nilay Vaish | Jan. 14, 2013, 9:12 p.m. | Open |
| I think long term there is a better way, but in the short term this is much cleaner than the ... | Ali Saidi | Jan. 14, 2013, 11 p.m. | Open |
| Sorry to dredge this up, but I've seen a warning a couple of times that is caused by this line ... | Brandon Potter | July 28, 2015, 3:42 p.m. | Open |
Ship It!
Posted (Jan. 12, 2013, 12:50 p.m.)
In my opinion, we should remove all references to arm_detailed cpu from the scripts. It was a bad decision to include this cpu in the configuration scripts. We have ended up with several cluttered scripts. And we have created a precedence for developers / interested parties to submit / commit patches that add more such configurations to the existing scripts. I am not opposed to defining such configurations, in particular I am fine with the file O3_ARM_v7a.py. But including this configuration in all other scripts seems completely incorrect.
Posted (Jan. 14, 2013, 9:12 p.m.)
-
configs/common/CacheConfig.py (Diff revision 1) -
Ali, for how many different cpu configurations are you ready to carry out this analysis? There can be inifinitly many such configurations and this case-based analysis is not the way to go. Either we should remove this reference to arm_detailed, or figure out some other way to do this.
Posted (Jan. 14, 2013, 11 p.m.)
-
configs/common/CacheConfig.py (Diff revision 1) -
I think long term there is a better way, but in the short term this is much cleaner than the previous way, so we should stick with it for now.
Posted (July 28, 2015, 3:42 p.m.)
-
configs/common/CacheConfig.py (Diff revision 1) -
Sorry to dredge this up, but I've seen a warning a couple of times that is caused by this line due to this import inside the middle of this function.
"SyntaxWarning: import * only allowed at module level"
I found the following reference which suggests that it should not be possible to do what this code is trying to do.
https://docs.python.org/2/whatsnew/2.1.html#pep-227-nested-scopes
Is it possible to do this in a different way to get rid of the warning (and make this code work in general)?