ruby: Fixes fucntional writes to messages on the mandatory queue
Review Request #1634 - Created Jan. 14, 2013 and submitted
| Information | |
|---|---|
| Derek Hower | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9479:492458214ed4 --------------------------- ruby: Fixes fucntional writes to messages on the mandatory queue
Issue Summary
| Description | From | Last Updated | Status |
|---|---|---|---|
| I think we should create local variables for maximum of wBase and mBase, and minimum of wTail and mTail. Also ... | Nilay Vaish | Jan. 14, 2013, 3:32 a.m. | Open |
You need to add some explanation to the patch's description.
Description: |
|
|---|
-
src/mem/ruby/slicc_interface/RubyRequest.cc (Diff revision 1) -
I think we should create local variables for maximum of wBase and mBase, and minimum of wTail and mTail. Also try to pull out the variable written out of the for loop.
-
src/mem/ruby/slicc_interface/RubyRequest.cc (Diff revision 1) -
So as not to carry out not required comparisons again and again. And you need to press the publish button after writing your response.
Description: |
|
|||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+16 -10) |
I have committed this patch.