ext lib: add libfdt to enable flattened device tree support
Review Request #1650 - Created Jan. 17, 2013 and submitted
| Information | |
|---|---|
| Tony Gutierrez | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9475:c4239151d324 --------------------------- ext lib: add libfdt to enable flattened device tree support this patch adds libfdt, a library necessary for supporting flattened device tree support in current and future versions of the linux/android kernel for ARM.
Posted (Jan. 17, 2013, 12:36 a.m.)
I'm not opposed to code like this, but whenever we take in external code, there are license issues that we need to be careful of. I'd prefer to never see GPL language (and I believe that they give us permission to simply remove it). We also require license text on all files. Ali, Steve? You guys should look at this.
-
SConstruct (Diff revision 1) -
I'd like to see some readme file that contains some (even minimal) sort of documentation on what this thing is for, and where it came from.
-
ext/libfdt/fdt.h (Diff revision 1) -
This file has no license.
-
ext/libfdt/fdt.c (Diff revision 1) -
I think we should just drop the GPL part and only keep the BSD part of the license.
Review request changed
Updated (Jan. 17, 2013, 3:05 a.m.)
Description: |
|
||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+3523) |
As long as the code is bsd licensed, I'm happy.
Posted (Jan. 29, 2013, 12:21 a.m.)
Anybody have any objections to this?
