ext lib: add libfdt to enable flattened device tree support

Information
Submitter:	Tony Gutierrez
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9475:c4239151d324
---------------------------
ext lib: add libfdt to enable flattened device tree support

this patch adds libfdt, a library necessary for supporting
flattened device tree support in current and future versions of
the linux/android kernel for ARM.

Testing Done

Issue Summary

Description	From	Last Updated	Status
I'd like to see some readme file that contains some (even minimal) sort of documentation on what this thing is ...	Nathan Binkert	Jan. 17, 2013, 3:10 a.m.	Resolved
This file has no license.	Nathan Binkert	Jan. 17, 2013, 3:10 a.m.	Resolved
I think we should just drop the GPL part and only keep the BSD part of the license.	Nathan Binkert	Jan. 17, 2013, 3:10 a.m.	Resolved

I'm not opposed to code like this, but whenever we take in external code, there are license issues that we need to be careful of.  I'd prefer to never see GPL language (and I believe that they give us permission to simply remove it).  We also require license text on all files.

Ali, Steve?  You guys should look at this.

Tony Gutierrez Jan. 17, 2013, 12:43 a.m. (Jan. 17, 2013, 12:43 a.m.)

You're correct:

"libfdt is dual licensed: you can use it either under the terms of * the GPL, or the BSD license, at your option."

SConstruct (Diff revision 1)

I'd like to see some readme file that contains some (even minimal) sort of documentation on what this thing is for, and where it came from.

Show all issues

Tony Gutierrez Jan. 17, 2013, 12:43 a.m. (Jan. 17, 2013, 12:43 a.m.)
```
Ok, I can add a README.
```

ext/libfdt/fdt.h (Diff revision 1)

This file has no license.

Show all issues

Tony Gutierrez Jan. 17, 2013, 12:43 a.m. (Jan. 17, 2013, 12:43 a.m.)
```
Will fix and repost.
```

ext/libfdt/fdt.c (Diff revision 1)

I think we should just drop the GPL part and only keep the BSD part of the license.

Show all issues

Tony Gutierrez Jan. 17, 2013, 12:43 a.m. (Jan. 17, 2013, 12:43 a.m.)
```
Agreed.
```

Description:

~		Changeset 9475:425491d7f106
	~	Changeset 9475:c4239151d324

		ext lib: add libfdt to enable flattened device tree support

		this patch adds libfdt, a library necessary for supporting
		flattened device tree support in current and future versions of
		the linux/android kernel for ARM.

Diff:

Revision 2 (+3523)

Show changes

	SConstruct
	ext/libfdt/README
	ext/libfdt/SConscript
	ext/libfdt/fdt.h
	ext/libfdt/fdt.c
	ext/libfdt/fdt_empty_tree.c
	ext/libfdt/fdt_ro.c
	ext/libfdt/fdt_rw.c
	6 more

As long as the code is bsd licensed, I'm happy.

Anybody have any objections to this?

Ali Saidi Feb. 7, 2013, 12:06 a.m. (Feb. 7, 2013, 12:06 a.m.)
```
seems like it's been a week. Any last concerns anyone?
```

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Issue Summary

Description:

Changeset 9475:425491d7f106

Changeset 9475:c4239151d324

Diff:

Status: Closed (submitted)