checkpoint: move curTick from globals to eventq
Review Request #1664 - Created Jan. 24, 2013 and discarded
| Information | |
|---|---|
| Nilay Vaish | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9480:c1585edc3d31 --------------------------- checkpoint: move curTick from globals to eventq curTick is no longer a global variable. In future, we would likely move towards parallel simulation with multiple event queues. Hence, the curTick should be moved to the section on the event queue.
Posted (Jan. 24, 2013, 4:39 a.m.)
I think the need for this somewhat depends on the threading model. It seems possible to have a "global" curTick per thread using tls and i'd imagine that at a checkpoint all threads should reach a quantum barrier before a checkpoint is allowed to be generated. Furthermore, I think it requires changes to the checkpoint upgraded, since the curTick value would move. Out of curiosity, is this just a small piece of a large amount of code you've written for multithreading or is this just a single isolated change? Since I imagine there might be a few false starts while going down the threading path, we might want to wait until there some number of changes accumulate before committing small changes that might not stick around.