base: add some mathematical operators to Cycles class

Description

Changeset 9496:96c5401984f8
---------------------------
base: add some mathematical operators to Cycles class

Testing Done

Description	From	Last Updated	Status
I'm not a big fan of the - operator. Is it really needed? If it is used in many places, ...	Andreas Hansson	Jan. 31, 2013, 8:38 p.m.	Resolved
I don't really like the idea of the shift operators for a Cycle count. It feels really unintuitive to me. ...	Andreas Hansson	Jan. 31, 2013, 6:20 p.m.	Open

src/base/types.hh (Diff revision 1)

I'm not a big fan of the - operator. Is it really needed?

If it is used in many places, can we at least add an assert(c >= b.c)?

Show all issues

src/base/types.hh (Diff revision 1)

I don't really like the idea of the shift operators for a Cycle count. It feels really unintuitive to me.

Why are these needed?

Show all issues

Nilay Vaish Jan. 31, 2013, 8:38 p.m. (Jan. 31, 2013, 8:38 p.m.)

Because ruby uses the << operator in one of its coherency protocol.

Andreas Hansson Jan. 31, 2013, 10:18 p.m. (Jan. 31, 2013, 10:18 p.m.)

If we really need to shift things, I would still prefer to do it by going to a uint, do the shift, and then back to Cycles(res). Sounds reasonable?

~		Changeset 9486:ed62e6fcdb21
	~	Changeset 9496:96c5401984f8

		base: add some mathematical operators to Cycles class

You have a pending review.