stats: Add total calculation to python formula class

Information
Submitter:	Andreas Hansson
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9706:c874d053e378
---------------------------
stats: Add total calculation to python formula class

This patch adds total calculation to the formula class. This is done
by using puthon's AST module, which allows custom syntax trees to be
built. The original formula is taken, and the total is added to the
formula by manipulating the syntax tree. The tree is then evaluated to
get the total for the formula. In the event that python is unable to
evaluate the tree, NaN is returned.

As ScalarValues are treated as floats by eval, we need to extend the
total function to simply return the stat as is.

Testing Done

Issue Summary

Description	From	Last Updated	Status
Seems like you should save these so you don't have to recalculate them, no? You can also do except (ZeroDivisionError, ...	Nathan Binkert	April 23, 2013, 10:52 p.m.	Resolved
Why is the difference between a float and a scalar?	Nilay Vaish	April 23, 2013, 10:53 p.m.	Dropped

src/python/m5/stats/info.py (Diff revision 1)

Seems like you should save these so you don't have to recalculate them, no?

You can also do
except (ZeroDivisionError, ValueError):

Show all issues

Sascha Bischoff April 23, 2013, 8:34 p.m. (April 23, 2013, 8:34 p.m.)
```
You are correct. Changed.
```

src/python/m5/stats/info.py (Diff revision 1)

Why is the difference between a float and a scalar?

Show all issues

Sascha Bischoff April 23, 2013, 10:56 p.m. (April 23, 2013, 10:56 p.m.)

A scalar is the gem5 stats system specific type (as defined in info.py), whereas a float is the standard python float. We need to handle the float seperately as it does not have the same built-in methods as the scalar.

We have to deal with floats as value is called as part of calculating the total of a stat (which takes a stat, be it scalar, vector, formula, etc. and returns a float). Therefore, we need to handle the case where a float is passed to the function.

Description:

~		Changeset 9512:10df991a6ac9
	~	Changeset 9706:c874d053e378

		stats: Add total calculation to python formula class

		This patch adds total calculation to the formula class. This is done
		by using puthon's AST module, which allows custom syntax trees to be
		built. The original formula is taken, and the total is added to the
		formula by manipulating the syntax tree. The tree is then evaluated to
		get the total for the formula. In the event that python is unable to
		evaluate the tree, NaN is returned.

		As ScalarValues are treated as floats by eval, we need to extend the
		total function to simply return the stat as is.

Diff:

Revision 2 (+57 -5)

Show changes

src/python/m5/stats/info.py

You have a pending review.

Review Board 2.0.15

Screenshots

Files

Issue Summary

Description:

Changeset 9512:10df991a6ac9

Changeset 9706:c874d053e378

Diff: