Review Board 2.0.15


Loader: Don't insert symbols into the symbol table that begin wiht '$'.

Review Request #169 - Created Aug. 13, 2010 and submitted

Information
Ali Saidi
gem5
Reviewers
Default 
Loader: Don't insert symbols into the symbol table that begin wiht '$'.

   

  


 


 

  

  









  
 


  

 
















 



 

  


 


  



   

   
Gabe Black

   
Posted  (Aug. 13, 2010, 4:45 p.m.)


  


  


  

   



  

   

   
    
    
   


  




   







    

     
     

      

       
        

         
          src/base/loader/elf_object.cc
          

           (Diff revision 1)

          
         
        

       
       
        
 


        
 


       
      

     

    

    


     
Are all symbols 100% guaranteed to be one character or longer? Is excluding symbols with "$" a universal behavior?

I honestly don't know the answers to those questions, but they make me a little nervous.




  

   

   
    
    

   
  1. 
    
    
     
    
      
     
    
     
    Well, the previous code ha that problem as well, but I've changed to to verify  that elf_strptr didn't return null. Symbols beginning with $ are normally internally compiler/assembler generated and just turn the output into a but of $a+XXX instead of something meaningful, so it should be fine to ignore them. 
    
    
    
   
    2.