etherlink: add simobjects at the endpoints to the link structure
Review Request #1700 - Created Feb. 10, 2013 and discarded
| Information | |
|---|---|
| Nilay Vaish | |
| gem5 | |
| default | |
| Reviewers | |
| Default | |
Changeset 9543:b01e713cf4ef --------------------------- etherlink: add simobjects at the endpoints to the link structure
Issue Summary
8
6
2
0
| Description | From | Last Updated | Status |
|---|---|---|---|
| It looks like this wouldn't work for the realview system, is that right? | Steve Reinhardt | Feb. 10, 2013, 12:26 p.m. | Open |
| It's a separate issue, but somehow it would be good to solve the naming or have some kind of alias ... | Andreas Hansson | Feb. 12, 2013, 3:08 a.m. | Open |
| Is it really SimObject we need? Is it not EventManagers? Perhaps I'm missing the point. | Andreas Hansson | Feb. 12, 2013, 3:08 a.m. | Open |
| I would be good to add a check that the values are sensible (no NULL), unless that's covered by the ... | Andreas Hansson | Feb. 12, 2013, 3:08 a.m. | Open |
| Is there a way we can derive int0/int1 from end0/end1, or vice versa? It seems redundant (and potentially error-prone) to ... | Steve Reinhardt | Feb. 12, 2013, 5:41 a.m. | Open |
| Does it make sense that we're only serializing one end of the link here? | Steve Reinhardt | Feb. 12, 2013, 5:41 a.m. | Open |
Posted (Feb. 10, 2013, 12:26 p.m.)
Nice! This is actually way simpler than I expected. Seems like at some point we'd want to (1) set the simulation quantum from the main script based on the etherlink delay and (2) maybe have a check in the etherlink object that asserts that if the SimObjects on the two ends belong to different event queues, then the simulation quantum is at least as large as the latency. I guess #2 is optional since you'd get an assertion once the simulation started running and handleAsyncInsertions() tried to schedule an event in the past (that's what should happen, anyway), but it would be friendlier to generate a cleaner error message up front.
-
configs/common/FSConfig.py (Diff revision 1) -
It looks like this wouldn't work for the realview system, is that right?
-
tests/configs/twosys-tsunami-simple-atomic.py (Diff revision 1) -
I think this is redundant, right? drive_sys should inherit eventq_index from root. For that matter, root should default to 0 as well, so only the 'test_sys.eventq_index = 1' line is strictly necessary. I'm not opposed to leaving the other lines in for documentation purposes.
Like Steve i find the changes required to be remarkably small (which is great!). Seeing as there is some subtleness to what is going on it would be very nice to have some comments about what is going on here. Otherwise I'm happy. Thanks again for making this happen, Ali
-
src/dev/Ethernet.py (Diff revision 1) -
A comment about what there are would be great?
-
src/dev/etherlink.hh (Diff revision 1) -
same here please
Posted (Feb. 12, 2013, 3:08 a.m.)
-
configs/common/FSConfig.py (Diff revision 1) -
It's a separate issue, but somehow it would be good to solve the naming or have some kind of alias for the common bits that does not involve tsunami, realview, pc etc. That would make the scripts much neater.
-
src/dev/Ethernet.py (Diff revision 1) -
Is it really SimObject we need? Is it not EventManagers? Perhaps I'm missing the point.
-
src/dev/etherlink.cc (Diff revision 1) -
I would be good to add a check that the values are sensible (no NULL), unless that's covered by the Python machinery.
Posted (Feb. 12, 2013, 5:41 a.m.)
-
configs/common/FSConfig.py (Diff revision 1) -
Is there a way we can derive int0/int1 from end0/end1, or vice versa? It seems redundant (and potentially error-prone) to have to set them separately.
-
src/dev/etherlink.cc (Diff revision 1) -
Does it make sense that we're only serializing one end of the link here?
Review request changed
Updated (Feb. 16, 2013, 1:44 a.m.)
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+36 -12) |
