arm: Enable support for triggering a sim panic on kernel panics

Information
Submitter:	Ali Saidi
Repository:	gem5
Branch:	default
Bugs:
Depends On:
Reviewers
Groups:	Default
People:

Description

Changeset 9537:8ad7ff7b8cfb
---------------------------
arm: Enable support for triggering a sim panic on kernel panics

Add the options 'panic_on_panic' and 'panic_on_oops' to the
LinuxArmSystem SimObject. When these option are enabled, the simulator
panics when the guest kernel panics or oopses. Enable panic on panic
and panic on oops in ARM-based test cases.

Testing Done

Cool idea.  I think that the default should be true.  My main question: why is this arm specific?  These functions are universal across ISAs.  If you were to parse the message (which would be cool and which we basically know how to do), then I could understand it perhaps being ISA specific (though templated)

Andreas Sandberg Feb. 13, 2013, 5:22 p.m. (Feb. 13, 2013, 5:22 p.m.)

The main reason it is ARM specific is that there is no LinuxSystem base class at the moment, so there is no obvious place for such functionality. We might want to refactor that at some point, but other than this, there doesn't seem to be a lot of opportunity for code sharing at the moment. The reason we/I decided not to enable the feature by default is that the panic message sometimes gets buffered and isn't always printed before the simulation terminates. The intention when the patch was designed was to prevent test cases from getting stuck if a guest kernel explodes.

You have a pending review.

Review Board 2.0.15

This change has been marked as submitted.

Screenshots

Files

Status: Closed (submitted)